github-actions[bot] commented on code in PR #61080:
URL: https://github.com/apache/doris/pull/61080#discussion_r2893369077
##########
fe/fe-core/pom.xml:
##########
@@ -770,6 +770,12 @@ under the License.
<artifactId>mockito-inline</artifactId>
<scope>test</scope>
</dependency>
+ <!-- fastutil for memory-efficient primitive collections -->
+ <dependency>
+ <groupId>it.unimi.dsi</groupId>
+ <artifactId>fastutil-core</artifactId>
+ <version>8.5.18</version>
+ </dependency>
Review Comment:
Nit: Most dependencies in this project have their versions managed centrally
in the parent `fe/pom.xml` `<dependencyManagement>` section. Consider adding
the fastutil-core version there instead of hardcoding it here, for consistency
with the project convention.
##########
dist/LICENSE-dist.txt:
##########
@@ -1085,7 +1085,7 @@ The Apache Software License, Version 2.0
* fastjson:
- com.alibaba:fastjson:1.2.58 (https://github.com/alibaba/fastjson)
* fastutil:
- - it.unimi.dsi:fastutil:6.5.6 (http://fasutil.dsi.unimi.it/)
+ - it.unimi.dsi:fastutil:8.5.18 (http://fastutil.di.unimi.it/)
* fe-common:
Review Comment:
Two issues here:
1. **Artifact name mismatch**: The pom.xml declares
`it.unimi.dsi:fastutil-core:8.5.18` but this LICENSE entry says
`it.unimi.dsi:fastutil:8.5.18`. These are different Maven artifacts
(`fastutil-core` is a ~7MB subset, `fastutil` is the full ~23MB library). This
should be `it.unimi.dsi:fastutil-core:8.5.18` to match the actual dependency.
2. **URL typo**: `http://fastutil.di.unimi.it/` should be
`http://fastutil.dsi.unimi.it/` (missing `s` in `dsi`). The old URL had a
different typo (`fasutil` instead of `fastutil`), but this new URL introduces a
new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
