github-actions[bot] commented on code in PR #61045:
URL: https://github.com/apache/doris/pull/61045#discussion_r2888665876
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -83,6 +83,7 @@
import org.apache.doris.catalog.TabletMeta;
import org.apache.doris.catalog.Type;
import org.apache.doris.catalog.View;
+import org.apache.doris.catalog.info.PartitionNamesInfo;
import org.apache.doris.clone.DynamicPartitionScheduler;
Review Comment:
Nit: The `@Override` annotation should be placed directly before the method
signature, not before the Javadoc comment. Java convention is:
```java
/** 0=case-sensitive, 1=stored lowercase, 2=case-insensitive comparison */
@Override
public int getLowerCaseTableNames() {
```
The current ordering (`@Override` then Javadoc then method) is unusual and
may confuse IDEs/linters.
##########
fe/fe-catalog/src/main/java/org/apache/doris/catalog/info/PartitionNamesInfo.java:
##########
@@ -15,9 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.info;
-
-import org.apache.doris.nereids.exceptions.AnalysisException;
+package org.apache.doris.catalog.info;
import com.google.common.base.Joiner;
Review Comment:
Minor: The exception type was changed from
`org.apache.doris.nereids.exceptions.AnalysisException` (a `RuntimeException`
subclass with semantic meaning) to bare `RuntimeException`. While verified safe
at all 13 call sites (no specific catch blocks exist), using a bare
`RuntimeException` loses the semantic signal that this is an
analysis/validation error. Consider using `IllegalArgumentException` or a
custom exception from `fe-catalog` to preserve that semantic meaning, which
also helps with future debugging and error categorization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
