Copilot commented on code in PR #61066:
URL: https://github.com/apache/doris/pull/61066#discussion_r2888149195
##########
regression-test/suites/external_table_p0/iceberg/test_iceberg_table_cache.groovy:
##########
@@ -302,8 +238,8 @@ suite("test_iceberg_table_cache", "p0,external") {
def rename_col_desc3 = sql """desc ${testDb}.test_rename_column"""
assertTrue(rename_col_desc3.toString().contains("new_name"))
- // Test 2.4: ALTER COLUMN TYPE
- logger.info("--- Test 2.4: External ALTER COLUMN TYPE ---")
+ // Test 2.2: ALTER COLUMN TYPE
+ logger.info("--- Test 2.2: External ALTER COLUMN TYPE ---")
spark_iceberg "DROP TABLE IF EXISTS demo.${testDb}.test_alter_type"
spark_iceberg "CREATE TABLE demo.${testDb}.test_alter_type (id INT,
value INT) USING iceberg"
spark_iceberg "INSERT INTO demo.${testDb}.test_alter_type VALUES (1,
100)"
Review Comment:
In the ALTER COLUMN TYPE test, the cached-schema assertion uses
`contains("int")`, but the expected new type `bigint` also contains the
substring `int`. This can make the test pass even if the cache is already
refreshed (or not caching). Use an exact comparison (e.g.,
equalsIgnoreCase("int")) or explicitly assert that the type is not `bigint` for
the cached/no-refresh case (and similarly tighten the initial schema check if
you want it to fail fast).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
