zclllyybb commented on code in PR #61047:
URL: https://github.com/apache/doris/pull/61047#discussion_r2883838207
##########
be/src/vec/functions/array/function_array_utils.cpp:
##########
@@ -58,7 +59,9 @@ bool extract_column_array_info(const IColumn& src,
ColumnArrayExecutionData& dat
data.nested_type->get_primitive_type() != PrimitiveType::TYPE_VARIANT)
{
// set variant root column/type to from column/type
auto variant = ColumnVariant::create(true /*always nullable*/);
- variant->create_root(data.nested_type,
make_nullable(data.nested_col)->assume_mutable());
+ auto nullable_nested_type = make_nullable(data.nested_type);
+ variant->create_root(nullable_nested_type,
+ make_nullable(data.nested_col)->assume_mutable());
Review Comment:
这里似乎是不能assume_mutable的，虽然我们一直这么用。这个列实际上来自src，在外层调用方可能是在某个函数里面，但是函数的block不能一致保证里面都是就地构造的columns。只有非常清楚列的来源的地方才可以用assume_mutable。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
