Copilot commented on code in PR #60993: URL: https://github.com/apache/doris/pull/60993#discussion_r2877546317
########## regression-test/data/external_table_p0/iceberg/iceberg_schema_change_ddl.out: ########## @@ -22,7 +22,7 @@ email text Yes true \N 1 Alice 25 \N 95.5 \N 2 Bob 30 \N 87.2 \N 3 Charlie 22 \N 92.8 \N -4 David 28 123-456-7890 89.1 [email protected] +4 David 28 123-456-7890 89.09999999999999 [email protected] Review Comment: This golden output now asserts exact textual rendering of floating-point values (e.g. `89.09999999999999`), which tends to be backend/version-dependent and can make the regression test brittle. Consider adjusting the query/test to cast/round floating values to a stable representation (or avoid selecting raw FLOAT/DOUBLE in golden outputs) so the `.out` file remains deterministic and readable. ```suggestion 4 David 28 123-456-7890 89.1 [email protected] ``` ########## fe/fe-core/src/main/java/org/apache/doris/catalog/ColumnType.java: ########## @@ -272,9 +313,9 @@ public static void checkSupportSchemaChangeForComplexType(Type checkType, Type o checkSupportSchemaChangeForComplexType(((MapType) checkType).getValueType(), ((MapType) other).getValueType(), true); Review Comment: `checkSupportSchemaChangeForComplexType` now allows safe primitive promotions in nested types, and since MAP keys are validated via the same nested path, this would also allow changing MAP key type (e.g. INT→BIGINT) without throwing. MAP key type changes are generally unsafe (and this PR’s Iceberg path explicitly rejects them), so this method should special-case MAP to require key types be exactly equal (only allow promotions on the value type). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
