morningman commented on issue #60951: URL: https://github.com/apache/doris/issues/60951#issuecomment-3989773523
Thank you for such a comprehensive and well-structured proposal! This is a high-quality design document that clearly outlines the technical path for Snowflake dialect compatibility. We really appreciate the detailed analysis of the function signatures and the "decomposable" implementation strategy. We agree with your design principles, especially **G-5 (not altering existing function behavior)** and the prioritization of FE-layer solutions. The tiered classification (Tier 0-5) is very practical. Before we proceed, we have a few questions regarding the overall strategy and future maintainability: 1. **Compatibility Coverage Measurement**: How do you plan to measure the final compatibility coverage? For the goal of ">90% high-frequency function compatibility," will you be using a curated list of Snowflake functions to validate this metric? 2. **Handling Hard-to-Compat Functions**: For functions that cannot be easily handled by FE aliases or rewriting (e.g., complex `LATERAL FLATTEN` usage or `OBJECT_CONSTRUCT` NULL-skipping), do you envision these being handled primarily by the Dialect Converter Plugin? If so, should we consider consolidating more logic into the SQL Converter to keep the core engine clean, or do you see value in implementing specific BE functions for them? 3. **Dialect Conflict Management**: Regarding potential conflicts, if we introduce support for other dialects in the future (e.g., Databricks SQL), how do we plan to handle function name collisions or semantic differences (like the `SPLIT` parameter order you mentioned)? Should the alias registration mechanism be made dialect-aware to ensure isolation? We look forward to your thoughts on the questions above! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
