morningman opened a new pull request, #60978:
URL: https://github.com/apache/doris/pull/60978
### What problem does this PR solve?
Based on PR #60540 review suggestions:
1: Encapsulate _current_writer in VIcebergTableWriter
- Move _current_writer from public to private
- Add const getter method current_writer()
- Update SpillIcebergTableSinkLocalState to use getter
2: Split VIcebergSortWriter header-only into .h + .cpp
- Move all method implementations to viceberg_sort_writer.cpp
- Replace heavy includes (spill_stream.h, spill_stream_manager.h) with
forward declarations in header to reduce compilation dependencies
- Add comprehensive documentation comments to all methods and members
4: Fix error handling in VIcebergSortWriter::close()
- Track internal_status for intermediate operations
- Pass actual error status to underlying partition writer's close()
instead of the original caller status (which could be OK)
5: Add explicit do_sort() in _do_spill()
- Call _sorter->do_sort() before prepare_for_read() for clarity
- Add detailed comments explaining the relationship with
FullSorter::prepare_for_read() internal sorting
6: Fix typo 'SpillReadDerializeBlockTime' -> 'SpillReadDeserializeBlockTime'
- Fix counter name string in spill_iceberg_table_sink_operator.cpp
- Fix counter name string in operator.h (PipelineXSpillLocalState)
- Fix counter lookup string in spill_reader.h
- Fix member variable name _spill_read_derialize_block_timer
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
