github-actions[bot] commented on code in PR #60910:
URL: https://github.com/apache/doris/pull/60910#discussion_r2875835319
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinTableGeneratingFunctions.java:
##########
@@ -89,7 +93,8 @@ public class BuiltinTableGeneratingFunctions implements
FunctionHelper {
Review Comment:
**Nit: Indentation inconsistency.** This line has 20 spaces of indentation
(5 levels), but every other entry in this list uses 12 spaces (3 levels).
Should be aligned with the line above:
```java
tableGenerating(JsonEachText.class, "json_each_text"),
```
##########
be/src/vec/functions/function_fake.cpp:
##########
@@ -239,6 +267,8 @@ void register_function_fake(SimpleFunctionFactory& factory)
{
register_table_function_expand_outer<FunctionExplodeMap>(factory,
"explode_map");
register_table_function_expand_outer<FunctionExplodeJsonObject>(factory,
"explode_json_object");
+ register_function<FunctionJsonEach>(factory, "json_each");
+ register_function<FunctionJsonEachText>(factory, "json_each_text");
register_table_function_expand_outer_default<DataTypeString,
false>(factory, "explode_split");
register_table_function_expand_outer_default<DataTypeInt32,
false>(factory, "explode_numbers");
register_table_function_expand_outer_default<DataTypeInt64, false>(factory,
Review Comment:
**Missing outer variant registration.** Every other table function uses
`register_table_function_expand_outer` (e.g., `explode_json_object` on the line
above), which registers both `json_each` and `json_each_outer`. Using plain
`register_function` means `json_each_outer` / `json_each_text_outer` are not
available, so `LATERAL VIEW OUTER json_each(...)` will not work.
Consider changing to:
```cpp
register_table_function_expand_outer<FunctionJsonEach>(factory, "json_each");
register_table_function_expand_outer<FunctionJsonEachText>(factory,
"json_each_text");
```
And adding corresponding `JsonEachOuter.java` / `JsonEachTextOuter.java` FE
classes + registrations.
If omitting outer variants is intentional, please add a comment explaining
why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
