shuke987 opened a new pull request, #60924:
URL: https://github.com/apache/doris/pull/60924
### What problem does this PR solve?
## Summary
This PR fixes an FE recycle-bin cleanup bug that could cause the recycle
daemon to fail with an unexpected NPE.
## Root cause
In some edge cases, an ID could still exist in same-name index structures
while its recycle-time entry was already
removed.
The cleanup path then sorted IDs by recycle time and dereferenced missing
values.
## Changes
- Clean stale IDs before same-name erase logic.
- Filter IDs without recycle-time entries before sorting.
- Use safer recycle-time lookup during sort.
- Add defensive logging around erase/replay paths for easier diagnosis.
## Impact
- Prevents recycle daemon abnormal exit due to NPE in cleanup flow.
- Improves robustness of recycle-bin maintenance under inconsistent
metadata states.
## Validation
- Reproduced and verified locally in the target scenario.
- Confirmed daemon no longer exits on this path.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
