This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 0074f55f96 [refactor](array-type) Remove encoding info for array type 
(#14498)
0074f55f96 is described below

commit 0074f55f96f368e69870cf0ef21f000526596ad0
Author: xy720 <22125576+xy...@users.noreply.github.com>
AuthorDate: Wed Nov 23 11:45:47 2022 +0800

    [refactor](array-type) Remove encoding info for array type (#14498)
    
    Array column should not have encoding info because it use its sub columns' 
encoding info
    And this encoding info is never used and easy to make people confused.
    We should remove it.
---
 be/src/olap/rowset/segment_v2/encoding_info.cpp | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/be/src/olap/rowset/segment_v2/encoding_info.cpp 
b/be/src/olap/rowset/segment_v2/encoding_info.cpp
index 8f5ec0f818..7ba80492ee 100644
--- a/be/src/olap/rowset/segment_v2/encoding_info.cpp
+++ b/be/src/olap/rowset/segment_v2/encoding_info.cpp
@@ -82,19 +82,6 @@ struct TypeEncodingTraits<type, BIT_SHUFFLE, CppType,
     }
 };
 
-template <>
-struct TypeEncodingTraits<OLAP_FIELD_TYPE_ARRAY, BIT_SHUFFLE, CollectionValue> 
{
-    static Status create_page_builder(const PageBuilderOptions& opts, 
PageBuilder** builder) {
-        *builder = new 
BitshufflePageBuilder<OLAP_FIELD_TYPE_UNSIGNED_BIGINT>(opts);
-        return Status::OK();
-    }
-    static Status create_page_decoder(const Slice& data, const 
PageDecoderOptions& opts,
-                                      PageDecoder** decoder) {
-        *decoder = new 
BitShufflePageDecoder<OLAP_FIELD_TYPE_UNSIGNED_BIGINT>(data, opts);
-        return Status::OK();
-    }
-};
-
 template <>
 struct TypeEncodingTraits<OLAP_FIELD_TYPE_BOOL, RLE, bool> {
     static Status create_page_builder(const PageBuilderOptions& opts, 
PageBuilder** builder) {
@@ -263,7 +250,6 @@ EncodingInfoResolver::EncodingInfoResolver() {
 
     _add_map<OLAP_FIELD_TYPE_UNSIGNED_BIGINT, BIT_SHUFFLE>();
     _add_map<OLAP_FIELD_TYPE_UNSIGNED_INT, BIT_SHUFFLE>();
-    _add_map<OLAP_FIELD_TYPE_ARRAY, BIT_SHUFFLE>();
 
     _add_map<OLAP_FIELD_TYPE_LARGEINT, BIT_SHUFFLE>();
     _add_map<OLAP_FIELD_TYPE_LARGEINT, PLAIN_ENCODING>();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to