[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #14340: [feature](bitmap) Support in bitmap syntax and bitmap runtime filter

[GitBox]

BiteTheDDDDt commented on code in PR #14340:
URL: https://github.com/apache/doris/pull/14340#discussion_r1029079815


##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1868,6 +1913,25 @@ Status 
RuntimePredicateWrapper::get_push_vexprs(std::vector<doris::vectorized::V
         container->push_back(wrapper);
         break;
     }
+    case RuntimeFilterType::BITMAP_FILTER: {
+        // create a bitmap filter
+        TTypeDesc type_desc = create_type_desc(PrimitiveType::TYPE_BOOLEAN);
+        type_desc.__set_is_nullable(vprob_expr->root()->is_nullable());
+        TExprNode node;
+        node.__set_type(type_desc);
+        node.__set_node_type(TExprNodeType::BITMAP_PRED);
+        node.__set_opcode(TExprOpcode::RT_FILTER);
+        node.__isset.vector_opcode = true;
+        node.__set_vector_opcode(to_in_opcode(_column_return_type));
+        node.__set_is_nullable(vprob_expr->root()->is_nullable());

Review Comment:
   Maybe we can set is_nullable to false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org