mrhhsg commented on code in PR #14371:
URL: https://github.com/apache/doris/pull/14371#discussion_r1029053577
##########
be/src/vec/runtime/shared_hash_table_controller.h:
##########
@@ -38,36 +38,31 @@ namespace vectorized {
class VExprContext;
struct SharedHashTableEntry {
- SharedHashTableEntry(Status status_, void* hash_table_ptr_,
std::vector<Block>* blocks_,
+ SharedHashTableEntry(Status status_, void* hash_table_ptr_, const
std::vector<Block>& blocks_,
RuntimeFilterSlotsBase<VExprContext>*
runtime_filter_slots_)
: status(status_),
hash_table_ptr(hash_table_ptr_),
blocks(blocks_),
runtime_filter_slots(runtime_filter_slots_) {}
- SharedHashTableEntry(SharedHashTableEntry&& entry)
- : status(entry.status),
- hash_table_ptr(entry.hash_table_ptr),
- blocks(entry.blocks),
- runtime_filter_slots(entry.runtime_filter_slots) {}
static SharedHashTableEntry empty_entry_with_status(const Status& status) {
- return SharedHashTableEntry(status, nullptr, nullptr, nullptr);
+ return SharedHashTableEntry(status, nullptr, {}, nullptr);
}
Status status;
void* hash_table_ptr;
Review Comment:
'emtpy entry' just contains status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
