englefly commented on code in PR #14442:
URL: https://github.com/apache/doris/pull/14442#discussion_r1028275081
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -257,6 +257,65 @@ public int removeParentExpression(GroupExpression parent) {
return parentExpressions.size();
}
+ /**
Review Comment:
why move the position of these functions?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -139,7 +165,28 @@ public List<GroupExpression> clearPhysicalExpressions() {
}
public double getCostLowerBound() {
- return costLowerBound;
+ return -1D;
+ }
+
+ /**
+ * Get the lowest cost {@link
org.apache.doris.nereids.trees.plans.physical.PhysicalPlan}
+ * which meeting the physical property constraints in this Group.
Review Comment:
meeting -> satisfies
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -139,7 +165,28 @@ public List<GroupExpression> clearPhysicalExpressions() {
}
public double getCostLowerBound() {
- return costLowerBound;
+ return -1D;
Review Comment:
I think -0.01 is not an acceptable bound. who about return 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
