morrySnow commented on PR #14246: URL: https://github.com/apache/doris/pull/14246#issuecomment-1322342213
> > Hi, this PR is try to fix a problem in audit with multiple statements. however, u change the parser of nereids, the new optimizer of Doris. so u use 1.1.2 with Nereids switch on and found this problem? > > I found the problem in doris 1.1.2 (without Nereids), but i've read the source code on master, 1.1.2rc05 and 1.1.3rc02, this problem must occurs on all of the versions **(the reason has no relevance with Nereids, it is not a parse problem, the key is the behavior is not right when handling multiple statements and sending statements to audit queue, DorisSqlSeparator.g4 is used for spliting multiple statements to multi lines and sending these lines one by one)**. Maybe i need to recurrence this problem by using master branch. I will give you a feedback when i've test this scene on master branch. if DorisSqlSeparator.g4 is not apart of Nereids, i suggest to move this file to `fe/fe-core/src/main/antlr4/org/apache/doris/parser` and move code about parser from `NereidsParser.java` to new file in `org.apache.doris.parser`. btw, maybe the better way to do this, is to save the origin stmt string in `StatementBase` when we parse sql using `sql_parser.cup`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
