HappenLee commented on code in PR #14393:
URL: https://github.com/apache/doris/pull/14393#discussion_r1027291237


##########
be/src/vec/aggregate_functions/aggregate_function.h:
##########
@@ -198,6 +199,9 @@ class IAggregateFunction {
 
     virtual DataTypePtr get_serialized_type() const { return 
std::make_shared<DataTypeString>(); }
 
+    //only used to check java udaf jar is valided, so it's could retrn error 
for user before open phase
+    virtual Status check_udaf(const TFunction& fn) { return Status::OK(); }

Review Comment:
   should not be virtual function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to