juice928 commented on PR #60323:
URL: https://github.com/apache/doris/pull/60323#issuecomment-3850993039
👋 Hi, I'm an automated AI code review bot. I ran some checks on this PR and
found **1 point that might be worth attention** (could be false positives,
please use your judgment):
1. <strong>The access control for the new `brokers()` function appears more
permissive than standard administrative commands</strong>
-
[Location](https://github.com/apache/doris/blob/fc866559b029f724c459a16d7370e612395610e8/fe/fe-core/src/main/java/org/apache/doris/tablefunction/BrokersTableValuedFunction.java#L72-L77):
`fe/fe-core/src/main/java/org/apache/doris/tablefunction/BrokersTableValuedFunction.java:L72-L77`
- Impact: Sensitive infrastructure details like broker IPs might be
visible to non-admin users, potentially bypassing the restrictions enforced by
`SHOW BROKER`.
- Suggestion: Consider updating the privilege check to require `ADMIN` or
`OPERATOR` roles to ensure consistency with existing security policies.
If you find these suggestions disruptive, you can reply "stop" , and I'll
automatically skip this repository in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
