yiguolei commented on code in PR #60334:
URL: https://github.com/apache/doris/pull/60334#discussion_r2752328786


##########
be/src/pipeline/exec/operator.h:
##########
@@ -146,18 +146,21 @@ class OperatorBase {
 
     virtual void set_low_memory_mode(RuntimeState* state) {}
 
-    [[nodiscard]] virtual bool require_data_distribution() const { return 
false; }
+    // Return True if this operator relies on the bucket distribution(e.g. 
COLOCATE join, 1-phase AGG).
+    [[nodiscard]] virtual bool is_colocated_operator() const { return false; }
     OperatorPtr child() { return _child; }
     [[nodiscard]] bool followed_by_shuffled_operator() const {
         return _followed_by_shuffled_operator;
     }
-    void set_followed_by_shuffled_operator(bool followed_by_shuffled_operator) 
{
+    virtual void update_operator(const TPlanNode& tnode, bool 
followed_by_shuffled_operator,

Review Comment:
   should add very very detailed comment here, to explain why need this API 
using  examples



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to