BiteTheDDDDt opened a new pull request, #60389:
URL: https://github.com/apache/doris/pull/60389
### What problem does this PR solve?
This pull request introduces additional validation checks to ensure the
integrity of column sizes during projection and expression evaluation
operations. These changes help catch and report inconsistencies early,
improving the robustness and debuggability of the code.
**Validation and Error Handling Improvements:**
* Added checks in `OperatorXBase::do_projections` to return an internal
error if any intermediate projection is empty, or if the result column size
does not match the expected number of input rows, including detailed error
messages for easier debugging.
* Added validation after all intermediate projections to ensure the final
input block row count matches the original, returning an error if not.
* Added a check in the main projection loop of
`OperatorXBase::do_projections` to verify that the result column size matches
the input, with error reporting including the expression's debug string.
* Updated `VCaseExpr::execute_column` to return an internal error if the
result column size does not match the expected count, replacing the previous
debug assertion with a runtime check and descriptive error message.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
