yiguolei commented on code in PR #60253:
URL: https://github.com/apache/doris/pull/60253#discussion_r2740330140
##########
be/src/olap/comparison_predicate.h:
##########
@@ -139,22 +139,29 @@ class ComparisonPredicateBase final : public
ColumnPredicate {
return false;
}
- T tmp_min_value = get_zone_map_value<Type,
T>(statistic.first->cell_ptr());
- T tmp_max_value = get_zone_map_value<Type,
T>(statistic.second->cell_ptr());
+ using CompareType = std::conditional_t<is_string_type(Type),
StringRef, T>;
Review Comment:
感觉这里我们predicate 里存储的是std string，然后wrapper field 里也是string，我们似乎在把这俩都cast
成stringref 来搞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
