This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-4.0 by this push:
     new 69cddea479a branch-4.0: [test](hive-writer) Fix side-effect of 
test_hive_staging_dir test. (#60287)
69cddea479a is described below

commit 69cddea479ab774db4f8b43c35eaa94153ec3b6f
Author: Qi Chen <[email protected]>
AuthorDate: Wed Jan 28 15:43:08 2026 +0800

    branch-4.0: [test](hive-writer) Fix side-effect of test_hive_staging_dir 
test. (#60287)
    
    ### What problem does this PR solve?
    
    Problem Summary:
    
    ### Release note
    
    [test] (hive-writer) Fixed a side effect of the test_hive_staging_dir
    test in #60258.
    This test would delete the default staging root directory, potentially
    causing issues for other write tests.
    
    ### Check List (For Author)
    
    - Test <!-- At least one of them must be included. -->
        - [ ] Regression test
        - [ ] Unit Test
        - [ ] Manual test (add detailed scripts or steps below)
        - [ ] No need to test or manual test. Explain why:
    - [ ] This is a refactor/code format and no logic has been changed.
            - [ ] Previous test can cover this change.
            - [ ] No code files have been changed.
            - [ ] Other reason <!-- Add your reason?  -->
    
    - Behavior changed:
        - [ ] No.
        - [ ] Yes. <!-- Explain the behavior change -->
    
    - Does this need documentation?
        - [ ] No.
    - [ ] Yes. <!-- Add document PR link here. eg:
    https://github.com/apache/doris-website/pull/1214 -->
    
    ### Check List (For Reviewer who merge this PR)
    
    - [ ] Confirm the release note
    - [ ] Confirm test cases
    - [ ] Confirm document
    - [ ] Add branch pick label <!-- Add branch pick label that this PR
    should merge into -->
---
 .../suites/external_table_p0/hive/write/test_hive_staging_dir.groovy | 5 -----
 1 file changed, 5 deletions(-)

diff --git 
a/regression-test/suites/external_table_p0/hive/write/test_hive_staging_dir.groovy
 
b/regression-test/suites/external_table_p0/hive/write/test_hive_staging_dir.groovy
index 66e970fe31c..76c61729fe2 100644
--- 
a/regression-test/suites/external_table_p0/hive/write/test_hive_staging_dir.groovy
+++ 
b/regression-test/suites/external_table_p0/hive/write/test_hive_staging_dir.groovy
@@ -98,7 +98,6 @@ suite("test_hive_staging_dir", 
"p0,external,hive,external_docker,external_docker
             Hdfs hdfs = new Hdfs(hdfsUri, hdfsUser, context.config.dataPath + 
"/")
             fs = hdfs.fs
 
-            fs.delete(new Path(stagingDefaultWithUser), true)
             fs.delete(new Path(stagingRelPath), true)
             fs.delete(new Path(stagingAbsWithUser), true)
 
@@ -116,7 +115,6 @@ suite("test_hive_staging_dir", 
"p0,external,hive,external_docker,external_docker
             order_qt_q01 """ select * from `${tableRel}`"""
             assertTrue(fs.exists(new Path(stagingDefaultWithUser)),
                     "default staging dir not created: 
${stagingDefaultWithUser}")
-            fs.delete(new Path(stagingDefaultWithUser), true)
 
             sql """alter catalog ${catalogName} set properties 
('hive.staging_dir' = '${stagingRelBase}')"""
             sql """refresh catalog ${catalogName}"""
@@ -138,9 +136,6 @@ suite("test_hive_staging_dir", 
"p0,external,hive,external_docker,external_docker
             try_hive_docker """drop table if exists 
`${dbName}`.`${tableAbs}`"""
             try_sql """drop catalog if exists ${catalogName}"""
             if (fs != null) {
-                if (stagingDefaultWithUser != null) {
-                    fs.delete(new Path(stagingDefaultWithUser), true)
-                }
                 if (stagingRelPath != null) {
                     fs.delete(new Path(stagingRelPath), true)
                 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to