iaorekhov-1980 opened a new pull request, #60275:
URL: https://github.com/apache/doris/pull/60275

   ### What problem does this PR solve?
   
   This PR adds new configuration property **ldap_use_ssl** to enable usage of 
LDAPS to establish connection to LDAP instance.
   If **ldap_use_ssl** in ldap.conf is specified as **true** - LDAPS is used to 
create connection string.
   If **ldap_use_ssl** in ldap.conf is not specified or specified as **false** 
- LDAP is used to create connection string as now.
   
   Issue Number: close #60236 
   
   Related PR: #xxx
   
   Problem Summary:
   
   Currently it is not possible to use LDAPS to create connection to secured 
LDAP instances.
   New configuration property allows to connect to such instances, but default 
behavior still relies on LDAP as is.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [x] Yes. <!-- Explain the behavior change -->
   
   1. ldap.conf and LdapConfig.java - new configuration **ldap_use_ssl** 
property added
   2. LdapClient.java - introduced new method to generate URL connection string 
depending on value of **ldap_use_ssl** property
   3. LdapClientTest.java - introduced new test method to validate existing 
behavior (without specified **ldap_use_ssl** property) and new one (with 
**ldap_use_ssl** property specified to **true**) to generate correct connection 
strings.
   
   - Does this need documentation?
       - [X] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to