luwei16 commented on code in PR #59967:
URL: https://github.com/apache/doris/pull/59967#discussion_r2721069355
##########
be/src/vec/olap/vertical_block_reader.cpp:
##########
@@ -537,9 +547,166 @@ Status VerticalBlockReader::_unique_key_next_block(Block*
block, bool* eof) {
_eof = *eof;
return Status::OK();
}
- int target_block_row = 0;
+
+ // Value column processing - use batch optimization
auto target_columns = block->mutate_columns();
- size_t column_count = block->columns();
+ const size_t column_count = block->columns();
+
+ // Try to use batch optimization for value column compaction
+ // Only use batch optimization when sparse optimization is enabled
+ {
Review Comment:
Function is too long, consider refactoring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
