Mryange commented on code in PR #48720:
URL: https://github.com/apache/doris/pull/48720#discussion_r2719826959
##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -501,8 +513,8 @@ Status ExchangeSinkOperatorX::sink(RuntimeState* state,
vectorized::Block* block
(local_state.current_channel_idx + 1) %
local_state.channels.size();
} else if (_part_type == TPartitionType::HASH_PARTITIONED ||
_part_type == TPartitionType::BUCKET_SHFFULE_HASH_PARTITIONED ||
- _part_type == TPartitionType::OLAP_TABLE_SINK_HASH_PARTITIONED
||
- _part_type == TPartitionType::HIVE_TABLE_SINK_HASH_PARTITIONED)
{
+ _part_type == TPartitionType::HIVE_TABLE_SINK_HASH_PARTITIONED
||
+ _part_type == TPartitionType::OLAP_TABLE_SINK_HASH_PARTITIONED)
{
RETURN_IF_ERROR(local_state._writer->write(&local_state, state, block,
eos));
Review Comment:
感觉这个writer可以在初始化的时候就把local state保存下来，后面就不需要一直传递一个参数了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
