suxiaogang223 opened a new pull request, #60166:
URL: https://github.com/apache/doris/pull/60166
### What problem does this PR solve?
- Related PR: #53327
## Problem
Queries like `FOR VERSION AS OF '<tag>'` fail when the tag points to a
snapshot whose snapshot file has expired, even though the tag is still valid
and data should be retained by tag.
## Root Cause
Doris always translated time-travel requests into `scan.snapshot-id`. Paimon
validates snapshot-id against the current snapshot range; once a snapshot file
is expired, it is out of range and the query fails. Tag-based reads should use
`scan.tag-name` instead, which bypasses that snapshot range validation.
## Fix
Use `scan.tag-name` for tag-based time travel (`@tag` and `FOR VERSION AS OF
'<tag>'`), and keep `scan.snapshot-id` only for numeric snapshot-id queries.
Add regression coverage that:
- validates tag reads succeed after snapshot expiration
- validates direct snapshot-id reads against expired snapshots still fail
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
