eldenmoon commented on code in PR #14178:
URL: https://github.com/apache/doris/pull/14178#discussion_r1021016301
##########
regression-test/suites/query_p0/sql_functions/array_functions/test_array_functions.groovy:
##########
@@ -74,6 +75,7 @@ suite("test_array_functions") {
qt_select "SELECT k1, array_with_constant(10, null) from ${tableName}
ORDER BY k1"
qt_select "SELECT k1, array_with_constant(2, 'a') from ${tableName} ORDER
BY k1"
qt_select "SELECT k1, array_with_constant(2, 123) from ${tableName} ORDER
BY k1"
+ qt_select "SELECT k1, has_all(k2, k4) FROM ${tableName} ORDER BY k1"
Review Comment:
please add more test, and better add more literal test in
`regression-test/suites/query_p0/sql_functions/array_functions/test_array_functions_by_literal.groovy`,
include nullable and none nullable, data type conversion like `has_all([1,2,
3], [1.0]])`, abnormal test cases like `has_all([1,2, 3], null)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
