gavinchou commented on code in PR #59754:
URL: https://github.com/apache/doris/pull/59754#discussion_r2705588545
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -1435,6 +1507,9 @@ Status CloudMetaMgr::commit_txn(const StreamLoadContext&
ctx, bool is_2pc) {
auto st = retry_rpc("commit txn", req, &res,
&MetaService_Stub::commit_txn);
if (st.ok()) {
+ if (config::enable_cloud_notify_be_after_load_txn_commit) {
+ forward_notify_be_request_to_fe_async(ctx, res);
Review Comment:
why not just extend `send_stats_to_fe_async()` instead of adding new similar
logic?
strongly recomend to reduce duplicated logics or keep the implementation
simple.
and, this path is not a critical path, we dont event need to implement
`forward_notify_be_request_to_fe_async()` for the scenario when commit txn on
backends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
