924060929 commented on code in PR #12583:
URL: https://github.com/apache/doris/pull/12583#discussion_r1020159143
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -198,6 +220,10 @@ public PlanFragment visitPhysicalAggregate(
slotList.addAll(groupSlotList);
slotList.addAll(aggFunctionOutput);
outputTupleDesc = generateTupleDesc(slotList, null, context);
+
+ if (needSetSlotToNullable(outputExpressionList)) {
+ setSlotNullable(outputTupleDesc, slotList);
+ }
Review Comment:
if the method is simple enough, please let the code reader understand the
core logic without enter the method.
```suggestion
if
(containsGroupingScalarFunctioncOrVirtualSlot(outputExpressionList)) {
setNullableToNonVirtualSlotReference(outputTupleDesc,
slotList);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
