wenzhenghu commented on code in PR #59065:
URL: https://github.com/apache/doris/pull/59065#discussion_r2684951869


##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3750,6 +3750,30 @@ public static int metaServiceRpcRetryTimes() {
     })
     public static int first_error_msg_max_length = 256;
 
+    @ConfField(mutable = false, description = {
+        "是否启用文件缓存准入控制",
+        "Whether to enable file cache admission control"
+    })
+    public static boolean enable_file_cache_admission_control = false;
+
+    @ConfField(mutable = true, description = {
+        "存储准入规则的JSON文件路径",
+        "JSON file path for storing admission rules"
+    })
+    public static String file_cache_admission_control_json_file_path = "";
+
+    @ConfField(mutable = true, description = {
+        "准入规则自动刷新间隔(秒),设置为0关闭自动刷新",
+        "Auto-refresh interval for admission policies (seconds). Set to 0 to 
disable auto refresh"
+    })
+    public static int file_cache_admission_control_fresh_interval_s = 300;
+
+    @ConfField(mutable = true, description = {
+        "当没有匹配的准入规则时的默认行为:true=允许,false=拒绝",
+        "Default behavior when no matching admission rule is found: 
true=allow, false=deny"
+    })
+    public static boolean file_cache_admission_control_default_allow = false;

Review Comment:
   We discussed this internally and concluded that this parameter isn't 
actually necessary. In this PR, we plan to remove it directly. For data lake 
scenarios, tables not on the whitelist won't be cached. For internal table 
scenarios, tables not on the blacklist will be cached. If configuration needs 
to be provided in the future, it should differentiate between data lake and 
internal tables, and this can be considered together with the modifications to 
enable_file_cache and disable_file_cache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to