zclllyybb commented on code in PR #59206:
URL: https://github.com/apache/doris/pull/59206#discussion_r2677806645
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/format/DateTimeChecker.java:
##########
@@ -98,6 +98,67 @@ public static boolean isValidDateTime(String str) {
return INSTANCE.check(stringInspect).matched && stringInspect.eos();
}
+ /** check weather a datetime has timezone part */
+ public static boolean hasTimeZone(String str) {
+ str = str.trim();
+
+ if (!isValidDateTime(str)) {
+ return false;
+ }
+
+ if (str.endsWith("Z")) {
Review Comment:
this function has some problems. like we not only accept `Z`, also `z`,
`zuLu`... please check BE parsing function to get the correct logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
