Copilot commented on code in PR #59654:
URL: https://github.com/apache/doris/pull/59654#discussion_r2669313350
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -4889,6 +4915,7 @@ public TQueryOptions toThrift() {
tResult.setEnableParquetLazyMat(enableParquetLazyMat);
tResult.setEnableOrcLazyMat(enableOrcLazyMat);
tResult.setEnableParquetFilterByMinMax(enableParquetFilterByMinMax);
+ tResult.setEnableParquetFilePageCache(enableParquetFilePageCache);
Review Comment:
The field `enableParquetFilePageCache` is set twice in the `toThrift()`
method. Line 4903 already sets this field, making this line 4918 redundant.
Remove this duplicate assignment to avoid confusion and potential bugs.
##########
be/src/vec/exec/format/parquet/level_decoder.cpp:
##########
@@ -87,6 +87,7 @@ doris::Status doris::vectorized::LevelDecoder::init_v2(const
doris::Slice& level
}
size_t doris::vectorized::LevelDecoder::get_levels(doris::vectorized::level_t*
levels, size_t n) {
+ // toto template.
Review Comment:
There is a typo in the comment. "toto" should be "TODO" or "Note:" depending
on the intended meaning.
```suggestion
// TODO: template.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
