dutyu commented on code in PR #14006:
URL: https://github.com/apache/doris/pull/14006#discussion_r1017757295


##########
fe/fe-core/src/main/java/org/apache/doris/alter/SystemHandler.java:
##########
@@ -84,10 +84,11 @@ private void runAlterJobV2() {
             }
 
             List<Long> backendTabletIds = 
invertedIndex.getTabletIdsByBackendId(beId);
-            if (backendTabletIds.isEmpty() && 
Config.drop_backend_after_decommission) {
+            if ((backendTabletIds.isEmpty() || 
Env.getCurrentRecycleBin().allTabletsInRecycledStatus(backendTabletIds))

Review Comment:
   > `allTabletsInRecycledStatus` is expensive, maybe we should put 
`Config.drop_backend_after_decommission` as the first condition.
   
   Would be appreciate if you spend some time to review it again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to