This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-1.1-lts
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-1.1-lts by this push:
     new 58bfc07f4f fix bug: tpch-q12 invalid type (#12347) (#14111)
58bfc07f4f is described below

commit 58bfc07f4f242dec6f4f9d2b41d2c4f46d10bd1d
Author: starocean999 <40539150+starocean...@users.noreply.github.com>
AuthorDate: Wed Nov 9 16:57:20 2022 +0800

    fix bug: tpch-q12 invalid type (#12347) (#14111)
    
    In old planner, Predicate set its type in analyzeImpl(). However, function 
analyzeImpl() is in old planner path, but not in nereids path. And hence the 
type is invalid.
    
    Because all predicate has type bool, we set its type in constructor.
    
    Co-authored-by: minghong <minghong.z...@163.com>
---
 fe/fe-core/src/main/java/org/apache/doris/analysis/Predicate.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Predicate.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/Predicate.java
index cc4f4dcf5d..d03135ab7d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Predicate.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Predicate.java
@@ -29,11 +29,13 @@ public abstract class Predicate extends Expr {
 
     public Predicate() {
         super();
+        type = Type.BOOLEAN;
         this.isEqJoinConjunct = false;
     }
 
     protected Predicate(Predicate other) {
         super(other);
+        type = other.type;
         isEqJoinConjunct = other.isEqJoinConjunct;
     }
 
@@ -47,7 +49,6 @@ public abstract class Predicate extends Expr {
 
     @Override
     protected void analyzeImpl(Analyzer analyzer) throws AnalysisException {
-        type = Type.BOOLEAN;
         // values: true/false/null
         numDistinctValues = 3;
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to