yiguolei commented on code in PR #59569:
URL: https://github.com/apache/doris/pull/59569#discussion_r2664378098
##########
fe/fe-core/src/main/java/org/apache/doris/common/MarkedCountDownLatch.java:
##########
@@ -24,73 +24,143 @@
import java.util.List;
import java.util.Map.Entry;
import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
-public class MarkedCountDownLatch<K, V> extends CountDownLatch {
+public class MarkedCountDownLatch<K, V> {
+
+ private final Object lock = new Object();
private Multimap<K, V> marks;
private Multimap<K, V> failedMarks;
private Status st = Status.OK;
private int markCount = 0;
+ private CountDownLatch downLatch;
public MarkedCountDownLatch(int count) {
- super(count);
this.markCount = count;
+ this.downLatch = new CountDownLatch(count);
Review Comment:
如果这个构造函数去不掉，就说明有的时候，我们的这个count 可能不等于marks的数量，可能是有问题的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
