eldenmoon commented on code in PR #59183:
URL: https://github.com/apache/doris/pull/59183#discussion_r2660273270
##########
be/src/olap/rowset/segment_v2/variant/variant_column_writer_impl.h:
##########
@@ -144,21 +176,75 @@ class VariantColumnWriterImpl {
bool _is_finalized = false;
// for root column
std::unique_ptr<ColumnWriter> _root_writer;
- // unified sparse writers (single or bucket mode)
- UnifiedSparseColumnWriter _sparse_writer;
std::vector<std::unique_ptr<ColumnWriter>> _subcolumn_writers;
std::vector<ColumnWriterOptions> _subcolumn_opts;
-
- // staticstics which will be persisted in the footer
- VariantStatistics _statistics;
-
+ std::unique_ptr<VariantBinaryWriter> _binary_writer;
// hold the references of subcolumns indexes
std::vector<TabletIndexes> _subcolumns_indexes;
// hold the references of subcolumns info
std::unordered_map<std::string, TabletSchema::SubColumnInfo>
_subcolumns_info;
};
+class VariantDocCompactWriter : public ColumnWriter {
Review Comment:
add comment to this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
