wuguowei1994 opened a new pull request, #59532: URL: https://github.com/apache/doris/pull/59532
#### 1. Compiler warning handling in `be/CMakeLists.txt` * **Issue**: `-Wno-incompatible-pointer-types` was incorrectly applied to both C and C++ builds, together with overly broad warning suppressions. * **Fix**: Limited `-Wno-incompatible-pointer-types` to C compilation only and removed redundant flags (e.g. `-Wno-unknown-warning-option`) to avoid masking valid C++ diagnostics. #### 2. Signedness correctness in `be/src/util/bit_util.h` * **Issue**: Byte extraction used plain `char`, whose signedness is platform-dependent. * **Fix**: Replaced with `signed char` to ensure consistent signed-byte semantics and avoid sign-extension related issues. #### 3. Exception handling in `be/src/util/block_compression.cpp` * **Issue**: Caught `std::exception` by value, causing object slicing and triggering `-Wcatch-value` under `-Werror`. * **Fix**: Catch by `const std::exception&` to preserve polymorphism and eliminate the warning. #### 4. Exception handling in `be/src/util/deletion_vector.h` * **Issue**: `std::runtime_error` was caught by value, leading to the same `-Wcatch-value` failure. * **Fix**: Changed to `catch (const std::runtime_error&)`. #### 5. Reliable execution of `libxml2` `autogen.sh` in `thirdparty/build-thirdparty.sh` * **Issue**: Piping a `sed`-modified `autogen.sh` into `bash` caused `$0` to be incorrect, breaking directory checks inside the script. * **Fix**: Write the modified script to a temporary file, execute it directly, and clean it up afterward, ensuring correct `$0` handling and consistent behavior across environments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
