sjyango commented on code in PR #58993:
URL: https://github.com/apache/doris/pull/58993#discussion_r2659479579


##########
be/src/udf/python/python_udaf_client.h:
##########
@@ -27,6 +27,20 @@ class PythonUDAFClient;
 
 using PythonUDAFClientPtr = std::shared_ptr<PythonUDAFClient>;
 
+// Fixed-size binary metadata structure for UDAF operations (Request)
+// Total size: 34 bytes (removed client_id - place_id is globally unique)
+struct __attribute__((packed)) UDAFMetadata {
+    uint8_t operation; // 1 byte: UDAFOperation enum
+    int64_t place_id;  // 8 bytes: aggregate state identifier (globally unique)
+    // ACCUMULATE-specific metadata (25 bytes)
+    uint8_t is_single_place; // 1 byte: boolean (0 or 1)
+    int64_t row_start;       // 8 bytes: start row index
+    int64_t row_end;         // 8 bytes: end row index (exclusive)
+    int64_t place_offset;    // 8 bytes: offset within each place

Review Comment:
   That's right—place_offset is indeed redundant here, so I've removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to