yiguolei commented on code in PR #59488:
URL: https://github.com/apache/doris/pull/59488#discussion_r2659450475
##########
be/src/exec/olap_common.h:
##########
@@ -96,8 +96,9 @@ std::string cast_to_string(T value, int scale) {
template <PrimitiveType primitive_type>
class ColumnValueRange {
public:
- using CppType = std::conditional_t<primitive_type == TYPE_HLL, StringRef,
- typename
PrimitiveTypeTraits<primitive_type>::CppType>;
+ using CppType =
+ std::conditional_t<primitive_type == TYPE_HLL ||
is_string_type(primitive_type),
Review Comment:
这里的改动好像没必要，string type的cpp type 就是stringref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
