Copilot commented on code in PR #59515:
URL: https://github.com/apache/doris/pull/59515#discussion_r2655841874
##########
be/src/pipeline/exec/olap_scan_operator.cpp:
##########
@@ -56,7 +57,8 @@ Status OlapScanLocalState::_init_profile() {
RETURN_IF_ERROR(ScanLocalState<OlapScanLocalState>::_init_profile());
// Rows read from storage.
// Include the rows read from doris page cache.
- _scan_rows = ADD_COUNTER(_runtime_profile, "ScanRows", TUnit::UNIT);
+ _scan_rows = ADD_COUNTER(custom_profile(), "ScanRows", TUnit::UNIT);
Review Comment:
The method call `custom_profile()` appears to be undefined. Looking at the
surrounding code in this file, profile counters are typically added to
`_runtime_profile`, `_scanner_profile`, or `_segment_profile`. The method
`custom_profile()` is not defined in the base classes (PipelineXLocalStateBase,
ScanLocalState, etc.) and this will likely cause a compilation error. This
should probably be `_runtime_profile` instead to match the pattern used in line
69 and elsewhere in the codebase.
```suggestion
_scan_rows = ADD_COUNTER(_runtime_profile, "ScanRows", TUnit::UNIT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
