seawinde opened a new pull request, #59510:
URL: https://github.com/apache/doris/pull/59510
### What problem does this PR solve?
ConnectionContext maintains an aliveSessionSet in the Env class. The session
ID associated with a ConnectionContext is only removed from this set when
ConnectContext#cleanup() is explicitly called.
In certain scenarios—such as when a ConnectionContext is no longer in use—if
only ConnectContext#remove() is invoked without calling
ConnectContext#cleanup(), the session ID remains in Env#aliveSessionSet,
causing it to grow indefinitely and eventually leading to a memory leak.
Therefore, whenever a ConnectionContext is confirmed to be no longer needed,
ConnectContext#cleanup() must be called (e.g., in
AutoCloseConnectContext#close()). On the other hand, if the ConnectionContext
will still be used afterward, it's appropriate to call only
ConnectContext#remove() (e.g., in AutoCloseSessionVariable).
This PR standardizes the usage of these methods across the codebase to
prevent potential memory leaks.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [x] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
