HappenLee commented on code in PR #59207:
URL: https://github.com/apache/doris/pull/59207#discussion_r2649797674
##########
be/src/vec/columns/column.h:
##########
@@ -478,11 +479,19 @@ class IColumn : public COW<IColumn> {
* nan_direction_hint - see above.
*/
virtual void get_permutation(bool reverse, size_t limit, int
nan_direction_hint,
- Permutation& res) const {
+ HybridSorter& sorter, Permutation& res) const
{
throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
"get_permutation for " + get_name());
}
+#ifdef BE_TEST
Review Comment:
if only define for test maybe not be column.h better, which may all file
include column.h need to recompile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
