Zhaowei-Zhang-27 commented on code in PR #59157:
URL: https://github.com/apache/doris/pull/59157#discussion_r2649169887
##########
be/src/util/metrics.cpp:
##########
@@ -345,13 +346,12 @@ std::string MetricRegistry::to_prometheus(bool
with_tablet_metrics) const {
// Output
std::stringstream ss;
- std::string last_group_name;
+ std::unordered_set<std::string> exported_types;
Review Comment:
Added the unit test as requested. It verifies that TYPE lines don't
duplicate when metrics are registered in interleaved order. Ready for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
