starocean999 commented on code in PR #13953:
URL: https://github.com/apache/doris/pull/13953#discussion_r1014957872
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/GroupingInfo.java:
##########
@@ -89,7 +89,30 @@ public List<Expr> getPreRepeatExprs() {
}
public void substitutePreRepeatExprs(ExprSubstitutionMap smap, Analyzer
analyzer) {
+ ArrayList<Expr> originalPreRepeatExprs = new
ArrayList<>(preRepeatExprs);
preRepeatExprs = Expr.substituteList(preRepeatExprs, smap, analyzer,
true);
+
+ // remove unmaterialized slotRef from preRepeatExprs
+ ArrayList<Expr> materializedPreRepeatExprs = new ArrayList<>();
+ ArrayList<Expr> unMaterializedSlotRefs = new ArrayList<>();
+ for (int i = 0; i < preRepeatExprs.size(); ++i) {
+ Expr expr = preRepeatExprs.get(i);
+ if (expr instanceof SlotRef && !((SlotRef)
expr).getDesc().isMaterialized()) {
+ unMaterializedSlotRefs.add(originalPreRepeatExprs.get(i));
+ } else {
+ materializedPreRepeatExprs.add(expr);
+ }
+ }
+ preRepeatExprs = materializedPreRepeatExprs;
+
+ // remove unmaterialized slotRef from outputTupleSmap and
outputTupleDesc if there is any
+ for (Expr expr : unMaterializedSlotRefs) {
+ Expr rExpr = outputTupleSmap.get(expr);
+ outputTupleSmap.removeByRhsExpr(rExpr);
+ if (rExpr instanceof SlotRef) {
+ outputTupleDesc.getSlots().remove(((SlotRef) rExpr).getDesc());
Review Comment:
set unmaterialized is better, code is updated, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
