gavinchou commented on code in PR #59291:
URL: https://github.com/apache/doris/pull/59291#discussion_r2643033468
##########
cloud/src/meta-service/txn_lazy_committer.cpp:
##########
@@ -662,134 +652,40 @@ void TxnLazyCommitTask::commit() {
std::shuffle(partition_ids.begin(), partition_ids.end(), rng);
}
- for (int64_t partition_id : partition_ids) {
- auto& tmp_rowset_metas =
partition_to_tmp_rowset_metas[partition_id];
-
- // tablet_id -> TabletIndexPB
- std::map<int64_t, TabletIndexPB> tablet_ids;
- int64_t table_id = -1;
- {
- DCHECK(tmp_rowset_metas.size() > 0);
- int64_t first_tablet_id =
tmp_rowset_metas.begin()->second.tablet_id();
- TabletIndexPB first_tablet_index;
- std::tie(code_, msg_) = get_tablet_index(
- meta_reader, txn_kv_.get(), instance_id_, txn_id_,
first_tablet_id,
- &first_tablet_index, is_versioned_read);
- if (code_ != MetaServiceCode::OK) {
+ if (config::enable_cloud_parallel_txn_lazy_commit) {
Review Comment:
we should add a UT to cover parallel commit, by enabling this flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
