juruo-c commented on code in PR #59223: URL: https://github.com/apache/doris/pull/59223#discussion_r2640417651
########## be/src/vec/functions/array/function_array_cross_product.h: ########## @@ -0,0 +1,204 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <gen_cpp/Types_types.h> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column.h" +#include "vec/columns/column_array.h" +#include "vec/columns/column_nullable.h" +#include "vec/common/assert_cast.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_array.h" +#include "vec/data_types/data_type_nullable.h" +#include "vec/data_types/data_type_number.h" +#include "vec/functions/array/function_array_utils.h" +#include "vec/functions/function.h" +#include "vec/utils/util.hpp" + +namespace doris::vectorized { + +class FunctionArrayCrossProduct : public IFunction { +public: + using DataType = PrimitiveTypeTraits<TYPE_FLOAT>::DataType; + using ColumnType = PrimitiveTypeTraits<TYPE_FLOAT>::ColumnType; + + static constexpr auto name = "cross_product"; + String get_name() const override { return name; } + static FunctionPtr create() { return std::make_shared<FunctionArrayCrossProduct>(); } + size_t get_number_of_arguments() const override { return 2; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + if (arguments.size() != 2) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Invalid number of arguments for function {}", get_name()); + } + + if (arguments[0]->get_primitive_type() != TYPE_ARRAY || + arguments[1]->get_primitive_type() != TYPE_ARRAY) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Arguments for function {} must be arrays", get_name()); + } + + // return ARRAY<FLOAT> + return std::make_shared<DataTypeArray>( + std::make_shared<DataTypeFloat32>()); + } + + // strict semantics: do not allow NULL + bool use_default_implementation_for_nulls() const override { return false; } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + uint32_t result, size_t input_rows_count) const override { + const auto& arg1 = block.get_by_position(arguments[0]); + const auto& arg2 = block.get_by_position(arguments[1]); + + auto col1 = arg1.column->convert_to_full_column_if_const(); + auto col2 = arg2.column->convert_to_full_column_if_const(); + + if (col1->size() != col2->size()) { + return Status::RuntimeError( + fmt::format("function {} have different input array sizes: {} and {}", + get_name(), col1->size(), col2->size())); + } + + const ColumnArray* arr1 = nullptr; + const ColumnArray* arr2 = nullptr; + + if (const auto* nullable = + typeid_cast<const ColumnNullable*>(col1.get())) { + if (nullable->has_null()) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "First argument for function {} cannot be null", get_name()); + } + arr1 = assert_cast<const ColumnArray*>(nullable->get_nested_column_ptr().get()); + } else { + arr1 = assert_cast<const ColumnArray*>(col1.get()); + } + + if (const auto* nullable = + typeid_cast<const ColumnNullable*>(col2.get())) { + if (nullable->has_null()) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Second argument for function {} cannot be null", + get_name()); + } + arr2 = assert_cast<const ColumnArray*>(nullable->get_nested_column_ptr().get()); + } else { + arr2 = assert_cast<const ColumnArray*>(col2.get()); + } + + const ColumnFloat32* float1 = nullptr; + const ColumnFloat32* float2 = nullptr; + + if (const auto* nullable = + typeid_cast<const ColumnNullable*>(arr1->get_data_ptr().get())) { + if (nullable->has_null()) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "First argument for function {} cannot have null elements", + get_name()); + } + float1 = assert_cast<const ColumnFloat32*>(nullable->get_nested_column_ptr().get()); + } else { + float1 = assert_cast<const ColumnFloat32*>(arr1->get_data_ptr().get()); + } + + if (const auto* nullable = + typeid_cast<const ColumnNullable*>(arr2->get_data_ptr().get())) { + if (nullable->has_null()) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Second argument for function {} cannot have null elements", + get_name()); + } + float2 = assert_cast<const ColumnFloat32*>(nullable->get_nested_column_ptr().get()); + } else { + float2 = assert_cast<const ColumnFloat32*>(arr2->get_data_ptr().get()); + } + + const auto* offset1 = + assert_cast<const ColumnArray::ColumnOffsets*>(arr1->get_offsets_ptr().get()); + const auto* offset2 = + assert_cast<const ColumnArray::ColumnOffsets*>(arr2->get_offsets_ptr().get()); + + // prepare result data + auto nested_res = ColumnFloat32::create(); + auto offsets_res = ColumnArray::ColumnOffsets::create(); + auto& offsets_data = offsets_res->get_data(); + offsets_data.reserve(input_rows_count); + size_t current_offset = 0; + + size_t row_cnt = offset1->size(); + size_t prev_offset1 = 0; + size_t prev_offset2 = 0; + for (ssize_t row = 0; row < row_cnt; ++row) { + ssize_t size1 = offset1->get_data()[row] - prev_offset1; + ssize_t size2 = offset2->get_data()[row] - prev_offset2; + + if (size1 != size2) [[unlikely]] { + return Status::InvalidArgument( + "function {} have different input element sizes of array: {} and {}", + get_name(), size1, size2); + } + + if (size1 != 3 || size2 != 3) { Review Comment: I don't think so. One ensures length consistency between the two inputs, while the other enforces a fixed-size 3 requirement. ########## be/src/vec/functions/array/function_array_cross_product.h: ########## @@ -0,0 +1,204 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <gen_cpp/Types_types.h> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column.h" +#include "vec/columns/column_array.h" +#include "vec/columns/column_nullable.h" +#include "vec/common/assert_cast.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_array.h" +#include "vec/data_types/data_type_nullable.h" +#include "vec/data_types/data_type_number.h" +#include "vec/functions/array/function_array_utils.h" +#include "vec/functions/function.h" +#include "vec/utils/util.hpp" + +namespace doris::vectorized { + +class FunctionArrayCrossProduct : public IFunction { +public: + using DataType = PrimitiveTypeTraits<TYPE_FLOAT>::DataType; + using ColumnType = PrimitiveTypeTraits<TYPE_FLOAT>::ColumnType; + + static constexpr auto name = "cross_product"; + String get_name() const override { return name; } + static FunctionPtr create() { return std::make_shared<FunctionArrayCrossProduct>(); } + size_t get_number_of_arguments() const override { return 2; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + if (arguments.size() != 2) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Invalid number of arguments for function {}", get_name()); + } + + if (arguments[0]->get_primitive_type() != TYPE_ARRAY || + arguments[1]->get_primitive_type() != TYPE_ARRAY) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Arguments for function {} must be arrays", get_name()); + } + + // return ARRAY<FLOAT> + return std::make_shared<DataTypeArray>( + std::make_shared<DataTypeFloat32>()); + } + + // strict semantics: do not allow NULL + bool use_default_implementation_for_nulls() const override { return false; } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + uint32_t result, size_t input_rows_count) const override { + const auto& arg1 = block.get_by_position(arguments[0]); + const auto& arg2 = block.get_by_position(arguments[1]); + + auto col1 = arg1.column->convert_to_full_column_if_const(); + auto col2 = arg2.column->convert_to_full_column_if_const(); + + if (col1->size() != col2->size()) { + return Status::RuntimeError( + fmt::format("function {} have different input array sizes: {} and {}", + get_name(), col1->size(), col2->size())); + } + + const ColumnArray* arr1 = nullptr; + const ColumnArray* arr2 = nullptr; + + if (const auto* nullable = + typeid_cast<const ColumnNullable*>(col1.get())) { + if (nullable->has_null()) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "First argument for function {} cannot be null", get_name()); + } + arr1 = assert_cast<const ColumnArray*>(nullable->get_nested_column_ptr().get()); + } else { + arr1 = assert_cast<const ColumnArray*>(col1.get()); + } + + if (const auto* nullable = + typeid_cast<const ColumnNullable*>(col2.get())) { + if (nullable->has_null()) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Second argument for function {} cannot be null", + get_name()); + } + arr2 = assert_cast<const ColumnArray*>(nullable->get_nested_column_ptr().get()); + } else { + arr2 = assert_cast<const ColumnArray*>(col2.get()); + } + + const ColumnFloat32* float1 = nullptr; + const ColumnFloat32* float2 = nullptr; + + if (const auto* nullable = + typeid_cast<const ColumnNullable*>(arr1->get_data_ptr().get())) { Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
