gavinchou commented on code in PR #59107:
URL: https://github.com/apache/doris/pull/59107#discussion_r2634844140


##########
fe/fe-core/src/main/java/org/apache/doris/alter/CloudRollupJobV2.java:
##########
@@ -56,6 +57,7 @@
 
 public class CloudRollupJobV2 extends RollupJobV2 {
     private static final Logger LOG = 
LogManager.getLogger(CloudRollupJobV2.class);
+    private static final String REQUEST_IP = 
FrontendOptions.getLocalHostAddress();

Review Comment:
   why not just add a method to access 
org.apache.doris.service.FrontendOptions#localAddr directly instead of adding 
REQUEST_IP for every related object?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to