yiguolei commented on code in PR #13585: URL: https://github.com/apache/doris/pull/13585#discussion_r1013679027
########## be/src/service/internal_service.cpp: ########## @@ -64,12 +63,14 @@ static void thread_context_deleter(void* d) { } template <typename T> -class NewHttpClosure : public ::google::protobuf::Closure { +class NewClosure : public ::google::protobuf::Closure { Review Comment: rename it to ClosureWithMemtracker better? since new closure is too common... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org