gavinchou commented on code in PR #58459:
URL: https://github.com/apache/doris/pull/58459#discussion_r2621585443
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -567,7 +567,11 @@ InstanceRecycler::InstanceRecycler(std::shared_ptr<TxnKv>
txn_kv, const Instance
instance_info_(instance),
inverted_index_id_cache_(std::make_unique<InvertedIndexIdCache>(instance_id_,
txn_kv_)),
_thread_pool_group(std::move(thread_pool_group)),
- txn_lazy_committer_(std::move(txn_lazy_committer)) {
+ txn_lazy_committer_(std::move(txn_lazy_committer)),
+
delete_bitmap_lock_white_list_(std::make_shared<DeleteBitmapLockWhiteList>()),
+ resource_mgr_(std::make_shared<ResourceManager>(txn_kv_)) {
Review Comment:
what is resource_mgr_ for?
is mandatory for recycler?
##########
gensrc/proto/olap_file.proto:
##########
@@ -158,6 +158,9 @@ message RowsetMetaPB {
optional int64 visible_ts_ms = 1010;
optional string reference_instance_id = 1011; // For cluster snapshot
map<string, PackedSliceLocationPB> packed_slice_locations = 1012;
+
+ optional bool recycled_marked = 1013;
Review Comment:
use enum or change naming to `is_recycled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
