gavinchou commented on code in PR #59089:
URL: https://github.com/apache/doris/pull/59089#discussion_r2622571729
##########
be/src/cloud/cloud_delete_task.cpp:
##########
@@ -96,7 +96,12 @@ Status CloudDeleteTask::execute(CloudStorageEngine& engine,
const TPushReq& requ
RETURN_IF_ERROR(rowset_writer->build(rowset));
rowset->rowset_meta()->set_delete_predicate(std::move(del_pred));
- auto st = engine.meta_mgr().commit_rowset(*rowset->rowset_meta(), "");
+ auto st = engine.meta_mgr().prepare_rowset(*rowset_writer->rowset_meta(),
"");
+ if (!st.ok()) {
+ return st;
Review Comment:
LOG here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
