yiguolei commented on code in PR #59009:
URL: https://github.com/apache/doris/pull/59009#discussion_r2621613979


##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -341,6 +346,17 @@ Status ColumnReader::init(const ColumnMetaPB* meta) {
                                   _file_reader->path().native(), 
meta->column_id());
     }
 
+    if (_zone_map_index != nullptr) {
+        FieldType type = _type_info->type();
+        std::unique_ptr<WrapperField> 
min_value(WrapperField::create_by_type(type, _meta_length));
+        std::unique_ptr<WrapperField> 
max_value(WrapperField::create_by_type(type, _meta_length));
+        RETURN_IF_ERROR(_parse_zone_map(*_segment_zone_map, min_value.get(), 
max_value.get()));
+

Review Comment:
   我觉得,我们限定的严格一些,只有zonemap 中全部非null的时候,才给const filed 
复制,否者这个值为null,后面不需要考虑这么复杂的情况。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to