zclllyybb commented on code in PR #59014:
URL: https://github.com/apache/doris/pull/59014#discussion_r2616348900
##########
be/src/vec/functions/function_string.cpp:
##########
@@ -1343,6 +1432,9 @@ using FunctionFromBase64 =
FunctionStringOperateToNullType<FromBase64Impl>;
using FunctionStringAppendTrailingCharIfAbsent =
FunctionBinaryStringOperateToNullType<StringAppendTrailingCharIfAbsent>;
+using FunctionHammingDistance =
+ FunctionBinaryStringOperateToNullType<HammingDistanceImpl>;
Review Comment:
shouldn't use this template. for inputs with not same lengths, just raise an
error. not null. so `FunctionBinaryToType` and `StringFunctionImpl` may be
better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
